1.3.6 Partial Trade - Exploitable bug

[Kandria]

Not sure if it's best to post bugs here, or over on the thread for the release.
Found a major bug in trades, when it comes to partial trades.
Thankfully I can disable them to prevent the exploit

Right now the flow goes:
User A makes a partial trade and sends to User B
User B edits the trade, and it sends it BACK to User B

What it should flow is:
User A makes a partial trade and sends to User B
User B edits the trade, and it sends it BACK to User A

The exploitable part is this can happen
User A makes a partial trade and sends to User B
User B edits the trade and takes it out of partial mode, the trade sends back to user B in accept mode.
User B can accept the trade, without User A's input on if the edit is fair, acceptable, etc.

Attaching image to show "Kandriamage" returned "Kandriamage's" trade, this is the message gotten when the trade is sent back to User B rather than going to User A

 

[Kesstryl]

@Hall of Famer This might be important to look into

 

[Hall of Famer]

Hmm tbh this is the first time such an issue is reported, I will see what I can do to offer a fix. Though in future, I am thinking about adding a more comprehensive item/adopt market system that the original trade system may become deprecated, it kinda feels half baked since the beginning.

 

[Kesstryl]

Hmm tbh this is the first time such an issue is reported, I will see what I can do to offer a fix. Though in future, I am thinking about adding a more comprehensive item/adopt market system that the original trade system may become deprecated, it kinda feels half baked since the beginning.

any fixes yet?